Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim search text from beginning and the end. (fixes #1861) #1862

Merged
merged 3 commits into from
Oct 23, 2017

Conversation

serkanozer
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 94.049% when pulling d6f5f61 on serkanozer:master into 6c0ee59 on JedWatson:master.

@agirton
Copy link
Collaborator

agirton commented Jul 10, 2017

Hi @serkanozer thank you for the PR. Since users can add this in by overriding the filterOptions going to hold off on this one for now unless other users are needing it. The bigger the surface area, the harder it is to maintain.

@serkanozer
Copy link
Contributor Author

serkanozer commented Jul 12, 2017

Thanks @agirton . You are right actually we are using filterOptions in our app but the problem with is that its not a method for extension but replacement. When I want to add trimming I also need to define other basic defaults (ignoreCase ignoreAccents).

Also, this is the default behavior in http://selectize.github.io/selectize.js/ and https://harvesthq.github.io/chosen/ .Would be good to add it to defaults here as well

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 92.934% when pulling cabebb7 on serkanozer:master into 57ab8d0 on JedWatson:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 92.934% when pulling cabebb7 on serkanozer:master into 57ab8d0 on JedWatson:master.

@gwyneplaine gwyneplaine merged commit c89e5b3 into JedWatson:master Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants